public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Fedora Release Engineering <releng@fedoraproject.org>
To: git-commits@fedoraproject.org
Subject: [rpms/mono] rawhide: Fix application icons being missing from Gnome Dash
Date: Wed, 24 Jun 2026 09:29:53 GMT	[thread overview]
Message-ID: <178229339322.1.16304600453466350223.rpms-mono-9cbb13cb8c53@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/mono
Branch : rawhide
Commit : 9cbb13cb8c531f2fed6f259b00ad6304672e6050
Author : Fedora Release Engineering <releng@fedoraproject.org>
Date   : 2026-06-09T09:52:17+02:00
Stats  : +75/-1 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/mono/c/9cbb13cb8c531f2fed6f259b00ad6304672e6050?branch=rawhide

Log:
Fix application icons being missing from Gnome Dash

---
diff --git a/694cb61761a8ee51d404debbdb019f64d09b61c9.patch b/694cb61761a8ee51d404debbdb019f64d09b61c9.patch
new file mode 100644
index 0000000..3c1c0db
--- /dev/null
+++ b/694cb61761a8ee51d404debbdb019f64d09b61c9.patch
@@ -0,0 +1,67 @@
+From 694cb61761a8ee51d404debbdb019f64d09b61c9 Mon Sep 17 00:00:00 2001
+From: Esme Povirk <esme@codeweavers.com>
+Date: Sat, 6 Jun 2026 00:29:58 +0000
+Subject: [PATCH] System.Windows.Forms: Make WM_CLASS more consistent with
+ ICCCM.
+
+Also fixes https://gitlab.winehq.org/mono/mono/-/work_items/32
+---
+ .../System.Windows.Forms/XplatUIX11.cs        | 28 ++++++++++++++-----
+ 1 file changed, 21 insertions(+), 7 deletions(-)
+
+diff --git a/mcs/class/System.Windows.Forms/System.Windows.Forms/XplatUIX11.cs b/mcs/class/System.Windows.Forms/System.Windows.Forms/XplatUIX11.cs
+index 84464432e39..0d6f94f4313 100644
+--- a/mcs/class/System.Windows.Forms/System.Windows.Forms/XplatUIX11.cs
++++ b/mcs/class/System.Windows.Forms/System.Windows.Forms/XplatUIX11.cs
+@@ -2727,6 +2727,27 @@ internal override IntPtr CreateWindow (CreateParams cp)
+ 				}
+ 			}
+ 
++			string res_name;
++			string res_class;
++			
++			try {
++				res_class = Path.GetFileNameWithoutExtension (Environment.GetCommandLineArgs ()[0]);
++			}
++			catch (Exception) {
++				res_class = "Mono";
++			}
++
++			res_name = Environment.GetEnvironmentVariable ("RESOURCE_NAME");
++			if (res_name == null)
++				res_name = res_class.ToLowerInvariant ();
++
++			var classHints = new XClassHint
++			{
++				res_name = res_name,
++				res_class = res_class
++			};
++			XSetClassHint(DisplayHandle, hwnd.whole_window, ref classHints);
++
+ 			lock (XlibLock) {
+ 				XSelectInput(DisplayHandle, hwnd.whole_window, new IntPtr ((int)(SelectInputMask | EventMask.StructureNotifyMask | EventMask.PropertyChangeMask | Keyboard.KeyEventMask)));
+ 				if (hwnd.whole_window != hwnd.client_window)
+@@ -6099,11 +6120,6 @@ internal override bool Text(IntPtr handle, string text)
+ 			Hwnd hwnd = Hwnd.ObjectFromHandle(handle);
+ 			if (hwnd == null)
+ 				return true;
+-            var classHints = new XClassHint
+-            {
+-                res_name = text,
+-                res_class = text
+-            };
+ 
+ 			lock (XlibLock) {
+ 				XChangeProperty(DisplayHandle, hwnd.whole_window, _NET_WM_NAME, UTF8_STRING, 8,
+@@ -6115,8 +6131,6 @@ internal override bool Text(IntPtr handle, string text)
+ 				// to compound text if it's in a
+ 				// different charset.
+ 				XStoreName(DisplayHandle, hwnd.whole_window, text);
+-
+-				XSetClassHint(DisplayHandle, hwnd.whole_window, ref classHints);
+ 			}
+ 
+ 			return true;
+-- 
+GitLab
+

diff --git a/mono.spec b/mono.spec
index bab0222..69d7801 100644
--- a/mono.spec
+++ b/mono.spec
@@ -23,7 +23,7 @@
 
 Name:           mono
 Version:        6.14.1
-Release:        3%{?dist}
+Release:        4%{?dist}
 Summary:        Cross-platform, Open Source, .NET development framework
 
 License:        MIT
@@ -60,6 +60,9 @@ Patch13:	mono-6.6.0-fix-multi-arch-issue.patch
 Patch14:        mono-configure-c99.patch
 Patch15:        mono-6.12.0-correct-alloc-free-for-zlib.patch
 Patch16:        mono-6.14.0-arm64-fix-pointer-int.patch
+# Fix missing icons in Gnome Dash
+# https://gitlab.winehq.org/mono/mono/-/work_items/32
+Patch17:        https://gitlab.winehq.org/mono/mono/-/commit/694cb61761a8ee51d404debbdb019f64d09b61c9.patch
 
 BuildRequires: make
 BuildRequires:  bison
@@ -354,6 +357,7 @@ popd
 %patch -P 14 -p1
 %patch -P 15 -p1
 %patch -P 16 -p1
+%patch -P 17 -p1
 
 # don't build mono-helix-client which requires the helix-binaries to build
 sed -i 's|mono-helix-client||g' mcs/tools/Makefile
@@ -946,6 +950,9 @@ rm %{buildroot}%{_bindir}/mono-find-provides
 %files complete
 
 %changelog
+* Tue Jun 09 2026 Julian Sikorski <belegdol@fedoraproject.org> - 6.14.1-4
+- Fix application icons being missing from Gnome Dash
+
 * Fri Jan 16 2026 Fedora Release Engineering <releng@fedoraproject.org> - 6.14.1-3
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_44_Mass_Rebuild
 

                 reply	other threads:[~2026-06-24  9:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178229339322.1.16304600453466350223.rpms-mono-9cbb13cb8c53@fedoraproject.org \
    --to=releng@fedoraproject.org \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox