public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Yaakov Selkowitz <yselkowi@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/tigervnc] f43: Use _vpath_builddir instead of __cmake_builddir
Date: Thu, 18 Jun 2026 11:02:11 GMT	[thread overview]
Message-ID: <178178053198.1.14175415242460598298.rpms-tigervnc-f8607ba8eecd@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/tigervnc
            Branch : f43
            Commit : f8607ba8eecded7e842b61a7915a341eed7b1b5b
            Author : Yaakov Selkowitz <yselkowi@redhat.com>
            Date   : 2026-04-29T14:59:57-04:00
            Stats  : +2/-8 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/tigervnc/c/f8607ba8eecded7e842b61a7915a341eed7b1b5b?branch=f43

            Log:
            Use _vpath_builddir instead of __cmake_builddir

This is compatible back to at least RHEL 9.  (The spec already uses other
features which are incompatible with RHEL 8.)

---
diff --git a/tigervnc.spec b/tigervnc.spec
index ea16e58..740569d 100644
--- a/tigervnc.spec
+++ b/tigervnc.spec
@@ -257,12 +257,6 @@ export CFLAGS="$RPM_OPT_FLAGS -fpic"
 %endif
 export CXXFLAGS="$CFLAGS -std=c++11"
 
-%if 0%{?fedora} >= 35 || 0%{?rhel} >= 10
-%define __cmake_builddir %{_target_platform}
-
-mkdir -p %{__cmake_builddir}
-%endif
-
 %cmake -DCMAKE_INSTALL_UNITDIR=%{_unitdir}
 
 %cmake_build
@@ -285,7 +279,7 @@ autoreconf -fiv
         --disable-devel-docs \
         --disable-selective-werror
 
-make TIGERVNC_BUILDDIR="`pwd`/../../%{__cmake_builddir}" %{?_smp_mflags}
+make TIGERVNC_BUILDDIR="`pwd`/../../%{_vpath_builddir}" %{?_smp_mflags}
 popd
 %endif
 
@@ -301,7 +295,7 @@ rm -f %{buildroot}%{_docdir}/%{name}-%{version}/{README.rst,LICENCE.TXT}
 
 %if %{with xserver}
 pushd unix/xserver/hw/vnc
-%make_install TIGERVNC_BUILDDIR="`pwd`/../../../../%{__cmake_builddir}"
+%make_install TIGERVNC_BUILDDIR="`pwd`/../../../../%{_vpath_builddir}"
 popd
 
 # Install systemd unit file

                 reply	other threads:[~2026-06-18 11:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178178053198.1.14175415242460598298.rpms-tigervnc-f8607ba8eecd@fedoraproject.org \
    --to=yselkowi@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox