public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Dmitry Belyavskiy <beldmit@gmail.com>
To: git-commits@fedoraproject.org
Subject: [rpms/qt6-qtbase] rawhide: Attempt to build against OpenSSL 4
Date: Wed, 17 Jun 2026 07:38:23 GMT [thread overview]
Message-ID: <178168190341.1.9266745344290293415.rpms-qt6-qtbase-a825cb7ed28b@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/qt6-qtbase
Branch : rawhide
Commit : a825cb7ed28bad0a2b3b7fca3065bf7b68148cec
Author : Dmitry Belyavskiy <beldmit@gmail.com>
Date : 2026-06-16T20:11:17+02:00
Stats : +495/-1 in 2 file(s)
URL : https://src.fedoraproject.org/rpms/qt6-qtbase/c/a825cb7ed28bad0a2b3b7fca3065bf7b68148cec?branch=rawhide
Log:
Attempt to build against OpenSSL 4
---
diff --git a/qt6-qtbase.spec b/qt6-qtbase.spec
index 7184247..1ee11cf 100644
--- a/qt6-qtbase.spec
+++ b/qt6-qtbase.spec
@@ -48,7 +48,7 @@ BuildRequires: pkgconfig(libsystemd)
Name: qt6-qtbase
Summary: Qt6 - QtBase components
Version: 6.11.1
-Release: 3%{?dist}
+Release: 4%{?dist}
License: LGPL-3.0-only OR GPL-3.0-only WITH Qt-GPL-exception-1.0
Url: http://qt-project.org/
@@ -97,6 +97,8 @@ Patch56: qtbase-mysql.patch
# fix FTBFS against libglvnd-1.3.4+
Patch58: qtbase-libglvnd.patch
+Patch59: qtbase-openssl4.patch
+
# Do not check any files in %%{_qt6_plugindir}/platformthemes/ for requires.
# Those themes are there for platform integration. If the required libraries are
# not there, the platform to integrate with isn't either. Then Qt will just
@@ -947,6 +949,10 @@ make check -k ||:
%{_qt6_datadir}/wayland/protocols/
%changelog
+* Tue Jun 16 2026 Dmitry Belyavskiy <beldmit@gmail.com> - 6.11.1-4
+- Backport of upstream OpenSSL4 commit
+ https://github.com/qt/qtbase/commit/e806630e694d89f567cffa9c982d1f471089ecd8
+
* Fri Jun 12 2026 Yaakov Selkowitz <yselkowi@redhat.com> - 6.11.1-3
- Rebuilt for openssl 4.0
diff --git a/qtbase-openssl4.patch b/qtbase-openssl4.patch
new file mode 100644
index 0000000..0f65cba
--- /dev/null
+++ b/qtbase-openssl4.patch
@@ -0,0 +1,488 @@
+From e806630e694d89f567cffa9c982d1f471089ecd8 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?M=C3=A5rten=20Nordheim?= <marten.nordheim@qt.io>
+Date: Thu, 26 Mar 2026 15:45:13 +0100
+Subject: [PATCH] Update sources to support OpenSSL 4
+
+OpenSSL 4 now uses const in logical cases across its X.509 API; this
+patch updates Qt's TLS backend to compile against both 3.x and 4.x.
+
+To do this QT_OPENSSL4_CONST macro (expands to `const` on OpenSSL >= 4,
+empty otherwise) is introduced for functions which changed in OpenSSL 4.
+
+There were pre-existing functions that were already const in OpenSSL 3
+but were declared without const in Qt's wrapper layer - they have now
+been fixed with plain const.
+
+ASN1_STRING was made opaque in OpenSSL 4, so replace direct access with
+use of accessor functions through the wrappers.
+
+tst_qsslcertificate: add expected output for OpenSSL 4's slightly
+different extension formatting.
+tst_qsslsocket::ecdhServer: lock to TLS 1.2 as OpenSSL 4 no longer
+exports DH/ECDH parameters for TLS 1.3 sessions.
+
+Fixes: QTBUG-145221
+Pick-to: 6.11 6.8
+Change-Id: Ic3f7d3cf00dbcb5b4cd1a299d3608a7c694a3454
+Reviewed-by: Mate Barany <mate.barany@qt.io>
+Reviewed-by: Jonas Kvinge <jonas@jkvinge.net>
+---
+ src/plugins/tls/openssl/qopenssl_p.h | 6 +++
+ .../openssl/qsslsocket_openssl_symbols.cpp | 36 ++++++++---------
+ .../openssl/qsslsocket_openssl_symbols_p.h | 30 +++++++-------
+ src/plugins/tls/openssl/qx509_openssl.cpp | 39 ++++++++++---------
+ src/plugins/tls/openssl/qx509_openssl_p.h | 2 +-
+ .../cert-large-expiration-date.txt.4.0.0 | 39 +++++++++++++++++++
+ .../qsslcertificate/tst_qsslcertificate.cpp | 9 ++++-
+ .../network/ssl/qsslsocket/tst_qsslsocket.cpp | 5 +++
+ .../network/ssl/shared/qopenssl_symbols.h | 17 ++++----
+ 9 files changed, 122 insertions(+), 61 deletions(-)
+ create mode 100644 tests/auto/network/ssl/qsslcertificate/more-certificates/cert-large-expiration-date.txt.4.0.0
+
+diff --git a/src/plugins/tls/openssl/qopenssl_p.h b/src/plugins/tls/openssl/qopenssl_p.h
+index 75b70925474a..f3920cba3b4a 100644
+--- a/src/plugins/tls/openssl/qopenssl_p.h
++++ b/src/plugins/tls/openssl/qopenssl_p.h
+@@ -69,6 +69,12 @@
+ #include <openssl/tls1.h>
+ #include <openssl/dh.h>
+
++#if defined(OPENSSL_VERSION_MAJOR) && OPENSSL_VERSION_MAJOR >= 4
++#define QT_OPENSSL4_CONST const
++#else
++#define QT_OPENSSL4_CONST
++#endif
++
+ QT_BEGIN_NAMESPACE
+
+ struct QSslErrorEntry {
+diff --git a/src/plugins/tls/openssl/qsslsocket_openssl_symbols.cpp b/src/plugins/tls/openssl/qsslsocket_openssl_symbols.cpp
+index 4e4d1d92ee38..c4a164edcc98 100644
+--- a/src/plugins/tls/openssl/qsslsocket_openssl_symbols.cpp
++++ b/src/plugins/tls/openssl/qsslsocket_openssl_symbols.cpp
+@@ -214,8 +214,8 @@ DEFINEFUNC2(void, BIO_set_shutdown, BIO *a, a, int shut, shut, return, DUMMYARG)
+
+ DEFINEFUNC(long, ASN1_INTEGER_get, ASN1_INTEGER *a, a, return 0, return)
+ DEFINEFUNC2(int, ASN1_INTEGER_cmp, const ASN1_INTEGER *a, a, const ASN1_INTEGER *b, b, return 1, return)
+-DEFINEFUNC(int, ASN1_STRING_length, ASN1_STRING *a, a, return 0, return)
+-DEFINEFUNC2(int, ASN1_STRING_to_UTF8, unsigned char **a, a, ASN1_STRING *b, b, return 0, return)
++DEFINEFUNC(int, ASN1_STRING_length, const ASN1_STRING *a, a, return 0, return)
++DEFINEFUNC2(int, ASN1_STRING_to_UTF8, unsigned char **a, a, const ASN1_STRING *b, b, return 0, return)
+ DEFINEFUNC2(int, ASN1_TIME_to_tm, const ASN1_TIME *s, s, struct tm *tm, tm, return 0, return)
+ DEFINEFUNC4(long, BIO_ctrl, BIO *a, a, int b, b, long c, c, void *d, d, return -1, return)
+ DEFINEFUNC(int, BIO_free, BIO *a, a, return 0, return)
+@@ -260,7 +260,7 @@ DEFINEFUNC(const char *, OBJ_nid2ln, int a, a, return nullptr, return)
+ DEFINEFUNC(int, OBJ_sn2nid, const char *s, s, return 0, return)
+ DEFINEFUNC(int, OBJ_ln2nid, const char *s, s, return 0, return)
+ DEFINEFUNC3(int, i2t_ASN1_OBJECT, char *a, a, int b, b, ASN1_OBJECT *c, c, return -1, return)
+-DEFINEFUNC4(int, OBJ_obj2txt, char *a, a, int b, b, ASN1_OBJECT *c, c, int d, d, return -1, return)
++DEFINEFUNC4(int, OBJ_obj2txt, char *a, a, int b, b, const ASN1_OBJECT *c, c, int d, d, return -1, return)
+ DEFINEFUNC(int, OBJ_obj2nid, const ASN1_OBJECT *a, a, return NID_undef, return)
+ DEFINEFUNC4(EVP_PKEY *, PEM_read_bio_PrivateKey, BIO *a, a, EVP_PKEY **b, b, pem_password_cb *c, c, void *d, d, return nullptr, return)
+
+@@ -347,31 +347,31 @@ DEFINEFUNC2(int, X509_cmp, X509 *a, a, X509 *b, b, return -1, return)
+ DEFINEFUNC4(int, X509_digest, const X509 *x509, x509, const EVP_MD *type, type, unsigned char *md, md, unsigned int *len, len, return -1, return)
+ DEFINEFUNC(X509 *, X509_dup, X509 *a, a, return nullptr, return)
+ DEFINEFUNC2(void, X509_print, BIO *a, a, X509 *b, b, return, DUMMYARG);
+-DEFINEFUNC(ASN1_OBJECT *, X509_EXTENSION_get_object, X509_EXTENSION *a, a, return nullptr, return)
++DEFINEFUNC(QT_OPENSSL4_CONST ASN1_OBJECT *, X509_EXTENSION_get_object, QT_OPENSSL4_CONST X509_EXTENSION *a, a, return nullptr, return)
+ DEFINEFUNC(void, X509_free, X509 *a, a, return, DUMMYARG)
+ //Q_AUTOTEST_EXPORT ASN1_TIME *q_X509_gmtime_adj(ASN1_TIME *s, long adj);
+ DEFINEFUNC2(ASN1_TIME *, X509_gmtime_adj, ASN1_TIME *s, s, long adj, adj, return nullptr, return)
+ DEFINEFUNC(void, ASN1_TIME_free, ASN1_TIME *t, t, return, DUMMYARG)
+-DEFINEFUNC2(X509_EXTENSION *, X509_get_ext, X509 *a, a, int b, b, return nullptr, return)
++DEFINEFUNC2(QT_OPENSSL4_CONST X509_EXTENSION *, X509_get_ext, X509 *a, a, int b, b, return nullptr, return)
+ DEFINEFUNC(int, X509_get_ext_count, X509 *a, a, return 0, return)
+ DEFINEFUNC4(void *, X509_get_ext_d2i, X509 *a, a, int b, b, int *c, c, int *d, d, return nullptr, return)
+-DEFINEFUNC(const X509V3_EXT_METHOD *, X509V3_EXT_get, X509_EXTENSION *a, a, return nullptr, return)
+-DEFINEFUNC(void *, X509V3_EXT_d2i, X509_EXTENSION *a, a, return nullptr, return)
+-DEFINEFUNC(int, X509_EXTENSION_get_critical, X509_EXTENSION *a, a, return 0, return)
+-DEFINEFUNC(ASN1_OCTET_STRING *, X509_EXTENSION_get_data, X509_EXTENSION *a, a, return nullptr, return)
++DEFINEFUNC(const X509V3_EXT_METHOD *, X509V3_EXT_get, QT_OPENSSL4_CONST X509_EXTENSION *a, a, return nullptr, return)
++DEFINEFUNC(void *, X509V3_EXT_d2i, QT_OPENSSL4_CONST X509_EXTENSION *a, a, return nullptr, return)
++DEFINEFUNC(int, X509_EXTENSION_get_critical, const X509_EXTENSION *a, a, return 0, return)
++DEFINEFUNC(QT_OPENSSL4_CONST ASN1_OCTET_STRING *, X509_EXTENSION_get_data, QT_OPENSSL4_CONST X509_EXTENSION *a, a, return nullptr, return)
+ DEFINEFUNC(void, BASIC_CONSTRAINTS_free, BASIC_CONSTRAINTS *a, a, return, DUMMYARG)
+ DEFINEFUNC(void, AUTHORITY_KEYID_free, AUTHORITY_KEYID *a, a, return, DUMMYARG)
+ DEFINEFUNC(void, GENERAL_NAME_free, GENERAL_NAME *a, a, return, DUMMYARG)
+ DEFINEFUNC2(int, ASN1_STRING_print, BIO *a, a, const ASN1_STRING *b, b, return 0, return)
+ DEFINEFUNC2(int, X509_check_issued, X509 *a, a, X509 *b, b, return -1, return)
+-DEFINEFUNC(X509_NAME *, X509_get_issuer_name, X509 *a, a, return nullptr, return)
+-DEFINEFUNC(X509_NAME *, X509_get_subject_name, X509 *a, a, return nullptr, return)
++DEFINEFUNC(QT_OPENSSL4_CONST X509_NAME *, X509_get_issuer_name, X509 *a, a, return nullptr, return)
++DEFINEFUNC(QT_OPENSSL4_CONST X509_NAME *, X509_get_subject_name, X509 *a, a, return nullptr, return)
+ DEFINEFUNC(ASN1_INTEGER *, X509_get_serialNumber, X509 *a, a, return nullptr, return)
+ DEFINEFUNC(int, X509_verify_cert, X509_STORE_CTX *a, a, return -1, return)
+-DEFINEFUNC(int, X509_NAME_entry_count, X509_NAME *a, a, return 0, return)
+-DEFINEFUNC2(X509_NAME_ENTRY *, X509_NAME_get_entry, X509_NAME *a, a, int b, b, return nullptr, return)
+-DEFINEFUNC(ASN1_STRING *, X509_NAME_ENTRY_get_data, X509_NAME_ENTRY *a, a, return nullptr, return)
+-DEFINEFUNC(ASN1_OBJECT *, X509_NAME_ENTRY_get_object, X509_NAME_ENTRY *a, a, return nullptr, return)
++DEFINEFUNC(int, X509_NAME_entry_count, const X509_NAME *a, a, return 0, return)
++DEFINEFUNC2(QT_OPENSSL4_CONST X509_NAME_ENTRY *, X509_NAME_get_entry, const X509_NAME *a, a, int b, b, return nullptr, return)
++DEFINEFUNC(QT_OPENSSL4_CONST ASN1_STRING *, X509_NAME_ENTRY_get_data, const X509_NAME_ENTRY *a, a, return nullptr, return)
++DEFINEFUNC(QT_OPENSSL4_CONST ASN1_OBJECT *, X509_NAME_ENTRY_get_object, const X509_NAME_ENTRY *a, a, return nullptr, return)
+ DEFINEFUNC(EVP_PKEY *, X509_PUBKEY_get, X509_PUBKEY *a, a, return nullptr, return)
+ DEFINEFUNC(void, X509_STORE_free, X509_STORE *a, a, return, DUMMYARG)
+ DEFINEFUNC(X509_STORE *, X509_STORE_new, DUMMYARG, DUMMYARG, return nullptr, return)
+@@ -670,9 +670,9 @@ static QStringList findAllLibCrypto()
+
+ #if (OPENSSL_VERSION_NUMBER >> 28) < 3
+ #define QT_OPENSSL_VERSION "1_1"
+-#elif OPENSSL_VERSION_MAJOR == 3 // Starting with 3.0 this define is available
+-#define QT_OPENSSL_VERSION "3"
+-#endif // > 3 intentionally left undefined
++#elif OPENSSL_VERSION_MAJOR >= 3
++#define QT_OPENSSL_VERSION QT_STRINGIFY(OPENSSL_VERSION_MAJOR)
++#endif
+
+ #ifdef Q_OS_WIN
+
+diff --git a/src/plugins/tls/openssl/qsslsocket_openssl_symbols_p.h b/src/plugins/tls/openssl/qsslsocket_openssl_symbols_p.h
+index 636f3e2c9b08..1b6fae226088 100644
+--- a/src/plugins/tls/openssl/qsslsocket_openssl_symbols_p.h
++++ b/src/plugins/tls/openssl/qsslsocket_openssl_symbols_p.h
+@@ -350,8 +350,8 @@ void q_SSL_set_psk_use_session_callback(SSL *s, q_SSL_psk_use_session_cb_func_t)
+ bool q_resolveOpenSslSymbols();
+ long q_ASN1_INTEGER_get(ASN1_INTEGER *a);
+ int q_ASN1_INTEGER_cmp(const ASN1_INTEGER *x, const ASN1_INTEGER *y);
+-int q_ASN1_STRING_length(ASN1_STRING *a);
+-int q_ASN1_STRING_to_UTF8(unsigned char **a, ASN1_STRING *b);
++int q_ASN1_STRING_length(const ASN1_STRING *a);
++int q_ASN1_STRING_to_UTF8(unsigned char **a, const ASN1_STRING *b);
+ int q_ASN1_TIME_to_tm(const ASN1_TIME *s, struct tm *tm);
+ long q_BIO_ctrl(BIO *a, int b, long c, void *d);
+ int q_BIO_free(BIO *a);
+@@ -402,7 +402,7 @@ const char *q_OBJ_nid2ln(int a);
+ int q_OBJ_sn2nid(const char *s);
+ int q_OBJ_ln2nid(const char *s);
+ int q_i2t_ASN1_OBJECT(char *buf, int buf_len, ASN1_OBJECT *obj);
+-int q_OBJ_obj2txt(char *buf, int buf_len, ASN1_OBJECT *obj, int no_name);
++int q_OBJ_obj2txt(char *buf, int buf_len, const ASN1_OBJECT *obj, int no_name);
+ int q_OBJ_obj2nid(const ASN1_OBJECT *a);
+ #define q_EVP_get_digestbynid(a) q_EVP_get_digestbyname(q_OBJ_nid2sn(a))
+ EVP_PKEY *q_PEM_read_bio_PrivateKey(BIO *a, EVP_PKEY **b, pem_password_cb *c, void *d);
+@@ -481,29 +481,29 @@ int q_X509_cmp(X509 *a, X509 *b);
+ X509 *q_X509_dup(X509 *a);
+ void q_X509_print(BIO *a, X509*b);
+ int q_X509_digest(const X509 *x509, const EVP_MD *type, unsigned char *md, unsigned int *len);
+-ASN1_OBJECT *q_X509_EXTENSION_get_object(X509_EXTENSION *a);
++QT_OPENSSL4_CONST ASN1_OBJECT *q_X509_EXTENSION_get_object(QT_OPENSSL4_CONST X509_EXTENSION *a);
+ void q_X509_free(X509 *a);
+ ASN1_TIME *q_X509_gmtime_adj(ASN1_TIME *s, long adj);
+ void q_ASN1_TIME_free(ASN1_TIME *t);
+-X509_EXTENSION *q_X509_get_ext(X509 *a, int b);
++QT_OPENSSL4_CONST X509_EXTENSION *q_X509_get_ext(X509 *a, int b);
+ int q_X509_get_ext_count(X509 *a);
+ void *q_X509_get_ext_d2i(X509 *a, int b, int *c, int *d);
+-const X509V3_EXT_METHOD *q_X509V3_EXT_get(X509_EXTENSION *a);
+-void *q_X509V3_EXT_d2i(X509_EXTENSION *a);
+-int q_X509_EXTENSION_get_critical(X509_EXTENSION *a);
+-ASN1_OCTET_STRING *q_X509_EXTENSION_get_data(X509_EXTENSION *a);
++const X509V3_EXT_METHOD *q_X509V3_EXT_get(QT_OPENSSL4_CONST X509_EXTENSION *a);
++void *q_X509V3_EXT_d2i(QT_OPENSSL4_CONST X509_EXTENSION *a);
++int q_X509_EXTENSION_get_critical(const X509_EXTENSION *a);
++QT_OPENSSL4_CONST ASN1_OCTET_STRING *q_X509_EXTENSION_get_data(QT_OPENSSL4_CONST X509_EXTENSION *a);
+ void q_BASIC_CONSTRAINTS_free(BASIC_CONSTRAINTS *a);
+ void q_AUTHORITY_KEYID_free(AUTHORITY_KEYID *a);
+ int q_ASN1_STRING_print(BIO *a, const ASN1_STRING *b);
+ int q_X509_check_issued(X509 *a, X509 *b);
+-X509_NAME *q_X509_get_issuer_name(X509 *a);
+-X509_NAME *q_X509_get_subject_name(X509 *a);
++QT_OPENSSL4_CONST X509_NAME *q_X509_get_issuer_name(X509 *a);
++QT_OPENSSL4_CONST X509_NAME *q_X509_get_subject_name(X509 *a);
+ ASN1_INTEGER *q_X509_get_serialNumber(X509 *a);
+ int q_X509_verify_cert(X509_STORE_CTX *ctx);
+-int q_X509_NAME_entry_count(X509_NAME *a);
+-X509_NAME_ENTRY *q_X509_NAME_get_entry(X509_NAME *a,int b);
+-ASN1_STRING *q_X509_NAME_ENTRY_get_data(X509_NAME_ENTRY *a);
+-ASN1_OBJECT *q_X509_NAME_ENTRY_get_object(X509_NAME_ENTRY *a);
++int q_X509_NAME_entry_count(const X509_NAME *a);
++QT_OPENSSL4_CONST X509_NAME_ENTRY *q_X509_NAME_get_entry(const X509_NAME *a, int b);
++QT_OPENSSL4_CONST ASN1_STRING *q_X509_NAME_ENTRY_get_data(const X509_NAME_ENTRY *a);
++QT_OPENSSL4_CONST ASN1_OBJECT *q_X509_NAME_ENTRY_get_object(const X509_NAME_ENTRY *a);
+ EVP_PKEY *q_X509_PUBKEY_get(X509_PUBKEY *a);
+ void q_X509_STORE_free(X509_STORE *store);
+ X509_STORE *q_X509_STORE_new();
+diff --git a/src/plugins/tls/openssl/qx509_openssl.cpp b/src/plugins/tls/openssl/qx509_openssl.cpp
+index 558671741031..d02d03062ac1 100644
+--- a/src/plugins/tls/openssl/qx509_openssl.cpp
++++ b/src/plugins/tls/openssl/qx509_openssl.cpp
+@@ -29,7 +29,7 @@ namespace QTlsPrivate {
+
+ namespace {
+
+-QByteArray asn1ObjectId(ASN1_OBJECT *object)
++QByteArray asn1ObjectId(const ASN1_OBJECT *object)
+ {
+ if (!object)
+ return {};
+@@ -40,7 +40,7 @@ QByteArray asn1ObjectId(ASN1_OBJECT *object)
+ return QByteArray(buf);
+ }
+
+-QByteArray asn1ObjectName(ASN1_OBJECT *object)
++QByteArray asn1ObjectName(const ASN1_OBJECT *object)
+ {
+ if (!object)
+ return {};
+@@ -52,14 +52,14 @@ QByteArray asn1ObjectName(ASN1_OBJECT *object)
+ return asn1ObjectId(object);
+ }
+
+-QMultiMap<QByteArray, QString> mapFromX509Name(X509_NAME *name)
++QMultiMap<QByteArray, QString> mapFromX509Name(const X509_NAME *name)
+ {
+ if (!name)
+ return {};
+
+ QMultiMap<QByteArray, QString> info;
+ for (int i = 0; i < q_X509_NAME_entry_count(name); ++i) {
+- X509_NAME_ENTRY *e = q_X509_NAME_get_entry(name, i);
++ const X509_NAME_ENTRY *e = q_X509_NAME_get_entry(name, i);
+
+ QByteArray name = asn1ObjectName(q_X509_NAME_ENTRY_get_object(e));
+ unsigned char *data = nullptr;
+@@ -147,7 +147,7 @@ QString x509ToText(X509 *x509)
+ return QString::fromLatin1(result);
+ }
+
+-QVariant x509UnknownExtensionToValue(X509_EXTENSION *ext)
++QVariant x509UnknownExtensionToValue(QT_OPENSSL4_CONST X509_EXTENSION *ext)
+ {
+ // Get the extension specific method object if available
+ // we cast away the const-ness here because some versions of openssl
+@@ -157,7 +157,7 @@ QVariant x509UnknownExtensionToValue(X509_EXTENSION *ext)
+
+ X509V3_EXT_METHOD *meth = const_cast<X509V3_EXT_METHOD *>(q_X509V3_EXT_get(ext));
+ if (!meth) {
+- ASN1_OCTET_STRING *value = q_X509_EXTENSION_get_data(ext);
++ QT_OPENSSL4_CONST ASN1_OCTET_STRING *value = q_X509_EXTENSION_get_data(ext);
+ Q_ASSERT(value);
+ QByteArray result( reinterpret_cast<const char *>(q_ASN1_STRING_get0_data(value)),
+ q_ASN1_STRING_length(value));
+@@ -237,9 +237,9 @@ QVariant x509UnknownExtensionToValue(X509_EXTENSION *ext)
+ * taken from RFC 5280, however we decided the capitalisation in the RFC
+ * was too silly for the real world.
+ */
+-QVariant x509ExtensionToValue(X509_EXTENSION *ext)
++QVariant x509ExtensionToValue(QT_OPENSSL4_CONST X509_EXTENSION *ext)
+ {
+- ASN1_OBJECT *obj = q_X509_EXTENSION_get_object(ext);
++ QT_OPENSSL4_CONST ASN1_OBJECT *obj = q_X509_EXTENSION_get_object(ext);
+ int nid = q_OBJ_obj2nid(obj);
+
+ // We cast away the const-ness here because some versions of openssl
+@@ -330,8 +330,9 @@ QVariant x509ExtensionToValue(X509_EXTENSION *ext)
+
+ // keyid
+ if (auth_key->keyid) {
+- QByteArray keyid(reinterpret_cast<const char *>(auth_key->keyid->data),
+- auth_key->keyid->length);
++ const unsigned char *data = q_ASN1_STRING_get0_data(auth_key->keyid);
++ int length = q_ASN1_STRING_length(auth_key->keyid);
++ QByteArray keyid(reinterpret_cast<const char *>(data), length);
+ result["keyid"_L1] = keyid.toHex();
+ }
+
+@@ -465,10 +466,10 @@ X509CertificateOpenSSL::subjectAlternativeNames() const
+ QHostAddress ipAddress;
+ switch (len) {
+ case 4: // IPv4
+- ipAddress = QHostAddress(qFromBigEndian(*reinterpret_cast<quint32 *>(genName->d.iPAddress->data)));
++ ipAddress = QHostAddress(qFromBigEndian(*reinterpret_cast<const quint32 *>(q_ASN1_STRING_get0_data(genName->d.iPAddress))));
+ break;
+ case 16: // IPv6
+- ipAddress = QHostAddress(reinterpret_cast<quint8 *>(genName->d.iPAddress->data));
++ ipAddress = QHostAddress(reinterpret_cast<const quint8 *>(q_ASN1_STRING_get0_data(genName->d.iPAddress)));
+ break;
+ default: // Unknown IP address format
+ break;
+@@ -562,9 +563,11 @@ QSslCertificate X509CertificateOpenSSL::certificateFromX509(X509 *x509)
+
+ if (ASN1_INTEGER *serialNumber = q_X509_get_serialNumber(x509)) {
+ QByteArray hexString;
+- hexString.reserve(serialNumber->length * 3);
+- for (int a = 0; a < serialNumber->length; ++a) {
+- hexString += QByteArray::number(serialNumber->data[a], 16).rightJustified(2, '0');
++ const unsigned char *serialNumberData = q_ASN1_STRING_get0_data(serialNumber);
++ int serialNumberLength = q_ASN1_STRING_length(serialNumber);
++ hexString.reserve(qsizetype(serialNumberLength) * 3);
++ for (int a = 0; a < serialNumberLength; ++a) {
++ hexString += QByteArray::number(serialNumberData[a], 16).rightJustified(2, '0');
+ hexString += ':';
+ }
+ hexString.chop(1);
+@@ -898,7 +901,7 @@ void X509CertificateOpenSSL::parseExtensions()
+ extensions.reserve(count);
+
+ for (int i = 0; i < count; i++) {
+- X509_EXTENSION *ext = q_X509_get_ext(x509, i);
++ QT_OPENSSL4_CONST X509_EXTENSION *ext = q_X509_get_ext(x509, i);
+ if (!ext) {
+ qCWarning(lcTlsBackend) << "Invalid (nullptr) extension at index" << i;
+ continue;
+@@ -911,13 +914,13 @@ void X509CertificateOpenSSL::parseExtensions()
+ QTlsBackendOpenSSL::clearErrorQueue();
+ }
+
+-X509CertificateBase::X509CertificateExtension X509CertificateOpenSSL::convertExtension(X509_EXTENSION *ext)
++X509CertificateBase::X509CertificateExtension X509CertificateOpenSSL::convertExtension(QT_OPENSSL4_CONST X509_EXTENSION *ext)
+ {
+ Q_ASSERT(ext);
+
+ X509CertificateExtension result;
+
+- ASN1_OBJECT *obj = q_X509_EXTENSION_get_object(ext);
++ QT_OPENSSL4_CONST ASN1_OBJECT *obj = q_X509_EXTENSION_get_object(ext);
+ if (!obj)
+ return result;
+
+diff --git a/src/plugins/tls/openssl/qx509_openssl_p.h b/src/plugins/tls/openssl/qx509_openssl_p.h
+index 8d5c1c7e46fd..e070a5dbe838 100644
+--- a/src/plugins/tls/openssl/qx509_openssl_p.h
++++ b/src/plugins/tls/openssl/qx509_openssl_p.h
+@@ -72,7 +72,7 @@ class X509CertificateOpenSSL final : public X509CertificateBase
+ static QSslError openSSLErrorToQSslError(int errorCode, const QSslCertificate &cert);
+ private:
+ void parseExtensions();
+- static X509CertificateExtension convertExtension(X509_EXTENSION *ext);
++ static X509CertificateExtension convertExtension(QT_OPENSSL4_CONST X509_EXTENSION *ext);
+
+ X509 *x509 = nullptr;
+
+diff --git a/tests/auto/network/ssl/qsslcertificate/more-certificates/cert-large-expiration-date.txt.4.0.0 b/tests/auto/network/ssl/qsslcertificate/more-certificates/cert-large-expiration-date.txt.4.0.0
+new file mode 100644
+index 000000000000..baa04baf117d
+--- /dev/null
++++ b/tests/auto/network/ssl/qsslcertificate/more-certificates/cert-large-expiration-date.txt.4.0.0
+@@ -0,0 +1,39 @@
++Certificate:
++ Data:
++ Version: 3 (0x2)
++ Serial Number:
++ ce:db:31:28:45:c4:05:40
++ Signature Algorithm: sha1WithRSAEncryption
++ Issuer: C=AU, ST=Some-State, O=Internet Widgits Pty Ltd
++ Validity
++ Not Before: Aug 4 09:53:41 2010 GMT
++ Not After : Aug 29 09:53:41 2051 GMT
++ Subject: C=AU, ST=Some-State, O=Internet Widgits Pty Ltd
++ Subject Public Key Info:
++ Public Key Algorithm: rsaEncryption
++ Public-Key: (1024 bit)
++ Modulus:
++ cd:aa:db:6f:d6:34:c9:a7:f1:c0:be:e4:41:18:19:e2:
++ 02:c9:22:e6:a7:d5:ba:03:2e:9e:28:7a:f4:5f:1a:77:
++ 5f:77:a9:11:3b:8f:7e:f0:2e:c6:9e:eb:3a:d9:12:d7:
++ c1:0c:51:e8:24:52:3f:23:c3:42:0c:11:c6:f2:1c:a1:
++ 42:fe:b4:c2:69:83:ad:f7:70:b1:18:15:cc:20:28:62:
++ 30:f0:2c:15:e6:33:19:af:c3:eb:1c:c0:91:f7:11:68:
++ 94:50:f8:49:37:08:32:d7:3e:75:df:a3:bc:69:00:15:
++ de:cd:87:0f:5c:02:6b:82:c8:01:7d:6a:f0:1d:dc:73
++ Exponent: 65537 (0x10001)
++ X509v3 extensions:
++ X509v3 Subject Key Identifier:
++ 8A:6E:19:E7:97:9B:8F:D9:7F:B3:BB:01:4F:E8:6A:2F:52:95:0D:D9
++ X509v3 Authority Key Identifier:
++ 8A:6E:19:E7:97:9B:8F:D9:7F:B3:BB:01:4F:E8:6A:2F:52:95:0D:D9
++ X509v3 Basic Constraints:
++ CA:TRUE
++ Signature Algorithm: sha1WithRSAEncryption
++ Signature Value:
++ a1:74:8e:5d:36:96:2c:05:7e:ea:66:cc:2e:68:c7:3d:93:dc:8c:a3:11:ad:b5:7e:
++ 6e:d0:04:c4:09:bd:0a:f9:39:3b:97:d7:f0:bb:0c:09:7b:83:fe:bf:87:b0:47:e8:
++ 94:b7:aa:9c:79:ad:71:9e:b7:c4:99:98:6f:1d:38:32:f8:a3:75:38:c4:e5:e7:37:
++ 37:21:ec:7b:50:8b:15:b0:97:1e:17:9c:50:17:3c:c1:df:94:55:fb:60:2e:50:40:
++ d1:ea:23:c6:3c:21:6f:97:8c:06:16:a5:82:72:c1:63:14:64:86:eb:d7:ff:72:f6:
++ 09:f5:6d:e6:04:13:7a:6a
+diff --git a/tests/auto/network/ssl/qsslcertificate/tst_qsslcertificate.cpp b/tests/auto/network/ssl/qsslcertificate/tst_qsslcertificate.cpp
+index c26fe979a123..f53fe246a836 100644
+--- a/tests/auto/network/ssl/qsslcertificate/tst_qsslcertificate.cpp
++++ b/tests/auto/network/ssl/qsslcertificate/tst_qsslcertificate.cpp
+@@ -1063,10 +1063,15 @@ void tst_QSslCertificate::toText()
+ QVERIFY(f305.open(QIODevice::ReadOnly | QFile::Text));
+ QByteArray txt305 = f305.readAll();
+
++ QFile f400(testDataDir + "more-certificates/cert-large-expiration-date.txt.4.0.0");
++ QVERIFY(f400.open(QIODevice::ReadOnly | QFile::Text));
++ QByteArray txt400 = f400.readAll();
++
+ QString txtcert = cert.toText();
+
+- QVERIFY(QString::fromLatin1(txt111) == txtcert ||
+- QString::fromLatin1(txt305) == txtcert);
++ QVERIFY2(QString::fromLatin1(txt111) == txtcert ||
++ QString::fromLatin1(txt305) == txtcert ||
++ QString::fromLatin1(txt400) == txtcert, u"Unexpected output: %1"_s.arg(txtcert).toUtf8().data());
+ }
+
+ void tst_QSslCertificate::multipleCommonNames()
+diff --git a/tests/auto/network/ssl/qsslsocket/tst_qsslsocket.cpp b/tests/auto/network/ssl/qsslsocket/tst_qsslsocket.cpp
+index 8121bd5dbe5b..3c4108a2f259 100644
+--- a/tests/auto/network/ssl/qsslsocket/tst_qsslsocket.cpp
++++ b/tests/auto/network/ssl/qsslsocket/tst_qsslsocket.cpp
+@@ -3653,6 +3653,7 @@ void tst_QSslSocket::ecdhServer()
+ if (cipher.isNull())
+ QSKIP("The current backend doesn't support ECDHE-RSA-AES128-SHA");
+ server.ciphers = {cipher};
++ server.protocol = QSsl::TlsV1_2;
+ QVERIFY(server.listen());
+
+ QEventLoop loop;
+@@ -3664,6 +3665,10 @@ void tst_QSslSocket::ecdhServer()
+ connect(socket, SIGNAL(sslErrors(QList<QSslError>)), this, SLOT(ignoreErrorSlot()));
+ connect(socket, SIGNAL(encrypted()), &loop, SLOT(quit()));
+
++ QSslConfiguration config = client.sslConfiguration();
++ config.setProtocol(QSsl::TlsV1_2);
++ client.setSslConfiguration(config);
++
+ client.connectToHostEncrypted(QHostAddress(QHostAddress::LocalHost).toString(), server.serverPort());
+
+ loop.exec();
+diff --git a/tests/auto/network/ssl/shared/qopenssl_symbols.h b/tests/auto/network/ssl/shared/qopenssl_symbols.h
+index c98e90d42409..78f774fbc676 100644
+--- a/tests/auto/network/ssl/shared/qopenssl_symbols.h
++++ b/tests/auto/network/ssl/shared/qopenssl_symbols.h
+@@ -143,10 +143,11 @@ OCSP_SINGLERESP *q_OCSP_basic_add1_status(OCSP_BASICRESP *rsp, OCSP_CERTID *cid,
+ int status, int reason, ASN1_TIME *revtime,
+ ASN1_TIME *thisupd, ASN1_TIME *nextupd);
+ int q_OCSP_basic_sign(OCSP_BASICRESP *brsp, X509 *signer, EVP_PKEY *key, const EVP_MD *dgst,
+- STACK_OF(X509) *certs, unsigned long flags);
++ const STACK_OF(X509) *certs, unsigned long flags);
+ OCSP_BASICRESP *q_OCSP_BASICRESP_new();
+ void q_OCSP_BASICRESP_free(OCSP_BASICRESP *bs);
+-OCSP_CERTID *q_OCSP_cert_to_id(const EVP_MD *dgst, X509 *subject, X509 *issuer);
++OCSP_CERTID *q_OCSP_cert_to_id(const EVP_MD *dgst, const X509 *subject,
++ const X509 *issuer);
+ void q_OCSP_CERTID_free(OCSP_CERTID *cid);
+
+ #endif // QT_CONFIG(ocsp)
+@@ -356,10 +357,12 @@ DEFINEFUNC(void, OCSP_RESPONSE_free, OCSP_RESPONSE *rs, rs, return, DUMMYARG)
+ DEFINEFUNC7(OCSP_SINGLERESP *, OCSP_basic_add1_status, OCSP_BASICRESP *r, r, OCSP_CERTID *c, c, int s, s,
+ int re, re, ASN1_TIME *rt, rt, ASN1_TIME *t, t, ASN1_TIME *n, n, return nullptr, return)
+ DEFINEFUNC6(int, OCSP_basic_sign, OCSP_BASICRESP *br, br, X509 *signer, signer, EVP_PKEY *key, key,
+- const EVP_MD *dg, dg, STACK_OF(X509) *cs, cs, unsigned long flags, flags, return 0, return)
++ const EVP_MD *dg, dg, const STACK_OF(X509) *cs, cs, unsigned long flags, flags, return 0, return)
+ DEFINEFUNC(OCSP_BASICRESP *, OCSP_BASICRESP_new, DUMMYARG, DUMMYARG, return nullptr, return)
+ DEFINEFUNC(void, OCSP_BASICRESP_free, OCSP_BASICRESP *bs, bs, return, DUMMYARG)
+-DEFINEFUNC3(OCSP_CERTID *, OCSP_cert_to_id, const EVP_MD *dgst, dgst, X509 *subject, subject, X509 *issuer, issuer, return nullptr, return)
++DEFINEFUNC3(OCSP_CERTID *, OCSP_cert_to_id, const EVP_MD *dgst, dgst,
++ const X509 *subject, subject, const X509 *issuer, issuer,
++ return nullptr, return)
+ DEFINEFUNC(void, OCSP_CERTID_free, OCSP_CERTID *cid, cid, return, DUMMYARG)
+
+ #endif // QT_CONFIG(ocsp)
+@@ -504,9 +507,9 @@ QStringList findAllLibCrypto()
+
+ #if (OPENSSL_VERSION_NUMBER >> 28) < 3
+ #define QT_OPENSSL_VERSION "1_1"
+-#elif OPENSSL_VERSION_MAJOR == 3 // Starting with 3.0 this define is available
+-#define QT_OPENSSL_VERSION "3"
+-#endif // > 3 intentionally left undefined
++#elif OPENSSL_VERSION_MAJOR >= 3
++#define QT_OPENSSL_VERSION QT_STRINGIFY(OPENSSL_VERSION_MAJOR)
++#endif
+
+ struct LoadedOpenSsl {
+ std::unique_ptr<QSystemLibrary> ssl, crypto;
reply other threads:[~2026-06-17 7:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178168190341.1.9266745344290293415.rpms-qt6-qtbase-a825cb7ed28b@fedoraproject.org \
--to=beldmit@gmail.com \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox