public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Nils Philippsen <nils@tiptoe.de>
To: git-commits@fedoraproject.org
Subject: [rpms/python-alembic1.14] rawhide: Fix failing tests
Date: Mon, 15 Jun 2026 10:48:24 GMT	[thread overview]
Message-ID: <178152050432.1.14252011070667602650.rpms-python-alembic1.14-07ec8e8b1e48@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/python-alembic1.14
            Branch : rawhide
            Commit : 07ec8e8b1e487672168fefb45ead356a6b5a1d65
            Author : Nils Philippsen <nils@tiptoe.de>
            Date   : 2026-06-15T12:47:34+02:00
            Stats  : +60/-0 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/python-alembic1.14/c/07ec8e8b1e487672168fefb45ead356a6b5a1d65?branch=rawhide

            Log:
            Fix failing tests

[skip changelog]

Signed-off-by: Nils Philippsen <nils@tiptoe.de>

---
diff --git a/0001-update-the-fk_names-req.patch b/0001-update-the-fk_names-req.patch
new file mode 100644
index 0000000..1741579
--- /dev/null
+++ b/0001-update-the-fk_names-req.patch
@@ -0,0 +1,60 @@
+From 20c108720d7127ca91acd6646f2ce5be408cc9f9 Mon Sep 17 00:00:00 2001
+From: Mike Bayer <mike_mp@zzzcomputing.com>
+Date: Fri, 31 Oct 2025 23:39:37 -0400
+Subject: [PATCH] update the fk_names req
+
+This is not a limitation this is just a bug in sqlalchemy,
+being fixed by #12954.    we dont have a system in place
+to cross-check gerrits right now so just merge this and then
+merge the SQLAlchemy fix
+
+Change-Id: I9c074c0edb9f55d2400e59a9b2b02603458e8f0b
+---
+ alembic/testing/suite/test_autogen_fks.py | 3 ++-
+ tests/requirements.py                     | 9 +++++++--
+ 2 files changed, 9 insertions(+), 3 deletions(-)
+
+diff --git a/alembic/testing/suite/test_autogen_fks.py b/alembic/testing/suite/test_autogen_fks.py
+index 0240b98d..355e244c 100644
+--- a/alembic/testing/suite/test_autogen_fks.py
++++ b/alembic/testing/suite/test_autogen_fks.py
+@@ -199,6 +199,7 @@ class AutogenerateForeignKeysTest(AutogenFixtureTest, TestBase):
+ 
+         eq_(diffs, [])
+ 
++    @config.requirements.fk_names
+     def test_casing_convention_changed_so_put_drops_first(self):
+         m1 = MetaData()
+         m2 = MetaData()
+@@ -247,7 +248,7 @@ class AutogenerateForeignKeysTest(AutogenFixtureTest, TestBase):
+             ["test2"],
+             "some_table",
+             ["test"],
+-            name="MyFK" if config.requirements.fk_names.enabled else None,
++            name="MyFK",
+         )
+ 
+         self._assert_fk_diff(
+diff --git a/tests/requirements.py b/tests/requirements.py
+index 4db5579e..b8c8a680 100644
+--- a/tests/requirements.py
++++ b/tests/requirements.py
+@@ -62,8 +62,13 @@ class DefaultRequirements(SuiteRequirements):
+ 
+     @property
+     def fk_names(self):
+-        """foreign key constraints always have names in the DB"""
+-        return exclusions.fails_on("sqlite")
++        """backend can reflect foreign key names"""
++
++        # issue here was fixed in SQLAlchemy #12954 for sqlite, 2.0
++        # release
++        return exclusions.fails_if(
++            lambda config: not sqla_compat.sqla_2 and config.against("sqlite")
++        )
+ 
+     @property
+     def reflects_fk_options(self):
+-- 
+2.54.0
+

                 reply	other threads:[~2026-06-15 10:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178152050432.1.14252011070667602650.rpms-python-alembic1.14-07ec8e8b1e48@fedoraproject.org \
    --to=nils@tiptoe.de \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox