public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Jason Tibbitts <tibbs@math.uh.edu>
To: git-commits@fedoraproject.org
Subject: [rpms/tig] v2.6.1: Play more with bash completion dir.
Date: Mon, 15 Jun 2026 07:23:01 GMT	[thread overview]
Message-ID: <178150818172.1.955250617245793023.rpms-tig-2e2ecb4914cc@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/tig
Branch : v2.6.1
Commit : 2e2ecb4914cc35891006f090649f7ca01ad84708
Author : Jason Tibbitts <tibbs@math.uh.edu>
Date   : 2016-08-11T13:49:57-05:00
Stats  : +12/-5 in 1 file(s)
URL    : https://src.fedoraproject.org/rpms/tig/c/2e2ecb4914cc35891006f090649f7ca01ad84708?branch=v2.6.1

Log:
Play more with bash completion dir.

---
diff --git a/tig.spec b/tig.spec
index 03d01b4..a155ab8 100644
--- a/tig.spec
+++ b/tig.spec
@@ -1,6 +1,8 @@
+%global bash_completion_dir %(pkg-config --variable=completionsdir bash-completion || echo /etc/bash_completion.d)/
+
 Name:           tig
 Version:        2.2
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        Text-mode interface for the git revision control system
 
 License:        GPLv2+
@@ -26,6 +28,7 @@ Using it as a pager, it will display input from stdin and colorize it.
 
 
 %prep
+echo %bash_completion_dir
 %autosetup
 
 
@@ -44,15 +47,15 @@ sed -i '/^#!bash/,+1 d' contrib/%{name}-completion.bash
 %make_install install-doc-man
 
 # Setup bash completion
-bashcompdir=$(pkg-config --variable=completionsdir bash-completion || echo /etc/bash_completion.d)
-install -Dpm 644 contrib/%{name}-completion.bash %{buildroot}$bashcompdir/%{name}
+install -Dpm 644 contrib/%{name}-completion.bash %{buildroot}%{bash_completion_dir}/%{name}
+ls -lR %buildroot
 
 
 %files
 %license COPYING
 %doc COPYING NEWS.adoc README.adoc *.html
 %{_bindir}/tig
-%{_datadir}/bash-completion/
+%{bash_completion_dir}
 %config(noreplace) %{_sysconfdir}/%{name}rc
 %{_mandir}/man1/tig.1*
 %{_mandir}/man5/tigrc.5*
@@ -60,12 +63,16 @@ install -Dpm 644 contrib/%{name}-completion.bash %{buildroot}$bashcompdir/%{name
 
 
 %changelog
+* Thu Aug 11 2016 Jason L Tibbitts III <tibbs@math.uh.edu> - 2.2-3
+- Move the bash completion dir thing into a macro.  I will probably just make
+  this a system-wide macro at some point.
+
 * Thu Aug 11 2016 Jason L Tibbitts III <tibbs@math.uh.edu> - 2.2-2
 - Handle case where pkg-config fails (EL6 and EL5).  Might as well test those
   magic EPEL RPM macros.
 - Use License tag.
 - Remove useless delete of test-graph; hasn't done anything for ages.
-- Use %make_install.
+- Use %%make_install.
 
 * Thu Aug 11 2016 Jason L Tibbitts III <tibbs@math.uh.edu> - 2.2-1
 - Update to 2.2.

                 reply	other threads:[~2026-06-15  7:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178150818172.1.955250617245793023.rpms-tig-2e2ecb4914cc@fedoraproject.org \
    --to=tibbs@math.uh.edu \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox