public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Jason Tibbitts <tibbs@math.uh.edu>
To: git-commits@fedoraproject.org
Subject: [rpms/tig] v2.6.1: Some spec cleanups.
Date: Mon, 15 Jun 2026 07:23:00 GMT	[thread overview]
Message-ID: <178150818032.1.5641112335791654043.rpms-tig-2f6fa52d9965@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/tig
Branch : v2.6.1
Commit : 2f6fa52d996512d265f1707bf28080f43b1e8daf
Author : Jason Tibbitts <tibbs@math.uh.edu>
Date   : 2016-08-11T10:00:30-05:00
Stats  : +5/-13 in 1 file(s)
URL    : https://src.fedoraproject.org/rpms/tig/c/2f6fa52d996512d265f1707bf28080f43b1e8daf?branch=v2.6.1

Log:
Some spec cleanups.

---
diff --git a/tig.spec b/tig.spec
index 6cacfa6..a85459d 100644
--- a/tig.spec
+++ b/tig.spec
@@ -3,11 +3,9 @@ Version:        2.2
 Release:        1%{?dist}
 Summary:        Text-mode interface for the git revision control system
 
-Group:          Development/Tools
 License:        GPLv2+
 URL:            http://jonas.nitro.dk/tig
 Source0:        http://jonas.nitro.dk/tig/releases/%{name}-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 BuildRequires:  git
 BuildRequires:  ncurses-devel
@@ -28,12 +26,12 @@ Using it as a pager, it will display input from stdin and colorize it.
 
 
 %prep
-%setup -q
+%autosetup
 
 
 %build
 %configure
-make %{?_smp_mflags} all doc-man doc-html
+%make_build all doc-man doc-html
 
 #Convert to unix line endings
 sed -i -e 's/\r//' *.html
@@ -43,8 +41,7 @@ sed -i '/^#!bash/,+1 d' contrib/%{name}-completion.bash
 
 
 %install
-rm -rf $RPM_BUILD_ROOT
-make install install-doc-man DESTDIR=$RPM_BUILD_ROOT prefix=%{_prefix} \
+make install install-doc-man DESTDIR=%{buildroot} prefix=%{_prefix} \
     mandir=%{_mandir}
 
 # Setup bash completion
@@ -52,20 +49,14 @@ bashcompdir=$(pkg-config --variable=completionsdir bash-completion)
 install -Dpm 644 contrib/%{name}-completion.bash %{buildroot}$bashcompdir/%{name}
 
 # Remove test-graph binary
-rm -f $RPM_BUILD_ROOT%{_bindir}/test-graph
-
-%clean
-rm -rf $RPM_BUILD_ROOT
+rm -f %{buildroot}%{_bindir}/test-graph
 
 
 %files
 %doc COPYING NEWS.adoc README.adoc *.html
-
 %{_bindir}/tig
-
 %{_datadir}/bash-completion/
 %config(noreplace) %{_sysconfdir}/%{name}rc
-
 %{_mandir}/man1/tig.1*
 %{_mandir}/man5/tigrc.5*
 %{_mandir}/man7/tigmanual.7*
@@ -74,6 +65,7 @@ rm -rf $RPM_BUILD_ROOT
 %changelog
 * Thu Aug 11 2016 Jason L Tibbitts III <tibbs@math.uh.edu> - 2.2-1
 - Update to 2.2.
+- Remove needless cruft from spec and be consistent about using %%buildroot.
 
 * Mon Jan 25 2016 Jason L Tibbitts III <tibbs@math.uh.edu> - 2.1.1-3
 - Remove pointless %%defattr statement.

             reply	other threads:[~2026-06-15  7:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-15  7:23 Jason Tibbitts [this message]
2026-06-15  7:23 [rpms/tig] v2.6.1: Some spec cleanups Jason Tibbitts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178150818032.1.5641112335791654043.rpms-tig-2f6fa52d9965@fedoraproject.org \
    --to=tibbs@math.uh.edu \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox