public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Mattias Ellert <mattias.ellert@physics.uu.se>
To: git-commits@fedoraproject.org
Subject: [rpms/globus-xio-pipe-driver] rawhide: Fix compiler warnings
Date: Sun, 14 Jun 2026 08:55:18 GMT	[thread overview]
Message-ID: <178142731829.1.12408505091427982024.rpms-globus-xio-pipe-driver-c0213017c744@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/globus-xio-pipe-driver
Branch : rawhide
Commit : c0213017c74489628ca82c04352eeee7c6cd02b1
Author : Mattias Ellert <mattias.ellert@physics.uu.se>
Date   : 2026-06-14T10:39:13+02:00
Stats  : +362/-1 in 3 file(s)
URL    : https://src.fedoraproject.org/rpms/globus-xio-pipe-driver/c/c0213017c74489628ca82c04352eeee7c6cd02b1?branch=rawhide

Log:
Fix compiler warnings

---
diff --git a/0001-Untabify-and-remove-trailing-white-space.patch b/0001-Untabify-and-remove-trailing-white-space.patch
new file mode 100644
index 0000000..9efa2b6
--- /dev/null
+++ b/0001-Untabify-and-remove-trailing-white-space.patch
@@ -0,0 +1,324 @@
+From 3ccdaa0236230bbcbcbf339e7dfdfaf23c10bd6f Mon Sep 17 00:00:00 2001
+From: Mattias Ellert <mattias.ellert@physics.uu.se>
+Date: Wed, 20 May 2026 00:15:37 +0200
+Subject: [PATCH 1/2] Untabify and remove trailing white-space
+
+---
+ .../pipe/source/globus_xio_pipe_driver.c      | 106 +++++++++---------
+ 1 file changed, 53 insertions(+), 53 deletions(-)
+
+diff --git a/xio/drivers/pipe/source/globus_xio_pipe_driver.c b/xio/drivers/pipe/source/globus_xio_pipe_driver.c
+index 8f476a4f0..c99811597 100644
+--- a/xio/drivers/pipe/source/globus_xio_pipe_driver.c
++++ b/xio/drivers/pipe/source/globus_xio_pipe_driver.c
+@@ -28,7 +28,7 @@ GlobusDebugDefine(GLOBUS_XIO_PIPE);
+     GlobusXIOPipeDebugPrintf(                                               \
+         GLOBUS_L_XIO_PIPE_DEBUG_TRACE,                                      \
+         (_XIOSL("[%s] Entering\n"), _xio_name))
+-        
++
+ #define GlobusXIOPipeDebugExit()                                            \
+     GlobusXIOPipeDebugPrintf(                                               \
+         GLOBUS_L_XIO_PIPE_DEBUG_TRACE,                                      \
+@@ -70,7 +70,7 @@ typedef struct xio_l_pipe_attr_s
+ {
+     globus_bool_t                       use_blocking_io;
+     globus_xio_system_file_t            infd;
+-    globus_xio_system_file_t            outfd;    
++    globus_xio_system_file_t            outfd;
+ } xio_l_pipe_attr_t;
+ 
+ /* default attr */
+@@ -194,7 +194,7 @@ globus_l_xio_pipe_attr_cntl(
+         case GLOBUS_XIO_PIPE_SET_OUT_HANDLE:
+             attr->outfd = va_arg(ap, globus_xio_system_file_t);
+             break;
+-            
++
+         default:
+             break;
+     }
+@@ -232,9 +232,9 @@ globus_l_xio_pipe_handle_init(
+ {
+     globus_result_t                     result;
+     GlobusXIOName(globus_l_xio_pipe_handle_init);
+-    
++
+     GlobusXIOPipeDebugEnter();
+-    
++
+     *handle = (xio_l_pipe_handle_t *)
+         globus_calloc(1, sizeof(xio_l_pipe_handle_t));
+     if(!*handle)
+@@ -242,7 +242,7 @@ globus_l_xio_pipe_handle_init(
+         result = GlobusXIOErrorMemory("handle");
+         goto error_handle;
+     }
+-    
++
+     globus_mutex_init(&(*handle)->lock, NULL);
+     (*handle)->use_blocking_io = attr->use_blocking_io;
+     (*handle)->infd = attr->infd;
+@@ -253,7 +253,7 @@ globus_l_xio_pipe_handle_init(
+ 
+ error_handle:
+     GlobusXIOPipeDebugExitWithError();
+-    return result;    
++    return result;
+ }
+ 
+ static
+@@ -262,12 +262,12 @@ globus_l_xio_pipe_handle_destroy(
+     xio_l_pipe_handle_t *               handle)
+ {
+     GlobusXIOName(globus_l_xio_pipe_handle_destroy);
+-    
++
+     GlobusXIOPipeDebugEnter();
+-    
++
+     globus_mutex_destroy(&handle->lock);
+     globus_free(handle);
+-    
++
+     GlobusXIOPipeDebugExit();
+ }
+ 
+@@ -287,9 +287,9 @@ globus_l_xio_pipe_open(
+     xio_l_pipe_attr_t *                 attr;
+     globus_result_t                     result;
+     GlobusXIOName(globus_l_xio_pipe_open);
+-    
++
+     GlobusXIOPipeDebugEnter();
+-    
++
+     attr = (xio_l_pipe_attr_t *)
+         (driver_attr ? driver_attr : &xio_l_pipe_attr_default);
+     result = globus_l_xio_pipe_handle_init(&handle, attr);
+@@ -314,9 +314,9 @@ globus_l_xio_pipe_open(
+             "globus_xio_system_file_init", result);
+         goto error_init;
+     }
+-    
++
+     globus_xio_driver_finished_open(handle, op, GLOBUS_SUCCESS);
+-    
++
+     GlobusXIOPipeDebugExit();
+     return GLOBUS_SUCCESS;
+ 
+@@ -341,18 +341,18 @@ globus_l_xio_pipe_close(
+     GlobusXIOName(globus_l_xio_pipe_close);
+ 
+     GlobusXIOPipeDebugEnter();
+-    
++
+     handle = (xio_l_pipe_handle_t *) driver_specific_handle;
+-    
++
+     globus_xio_system_file_destroy(handle->in_system);
+     globus_xio_system_file_destroy(handle->out_system);
+-    
++
+     globus_xio_system_file_close(handle->infd);
+     globus_xio_system_file_close(handle->outfd);
+-    
++
+     globus_xio_driver_finished_close(op, GLOBUS_SUCCESS);
+     globus_l_xio_pipe_handle_destroy(handle);
+-    
++
+     GlobusXIOPipeDebugExit();
+     return GLOBUS_SUCCESS;
+ }
+@@ -366,13 +366,13 @@ globus_l_xio_pipe_system_read_cb(
+ {
+     globus_xio_operation_t              op;
+     GlobusXIOName(globus_l_xio_pipe_system_read_cb);
+-    
++
+     GlobusXIOPipeDebugEnter();
+-    
++
+     op = (globus_xio_operation_t) user_arg;
+-    
++
+     globus_xio_driver_finished_read(op, result, nbytes);
+-    
++
+     GlobusXIOPipeDebugExit();
+ }
+ 
+@@ -393,9 +393,9 @@ globus_l_xio_pipe_read(
+     GlobusXIOName(globus_l_xio_pipe_read);
+ 
+     GlobusXIOPipeDebugEnter();
+-    
++
+     handle = (xio_l_pipe_handle_t *) driver_specific_handle;
+-    
++
+     /* if buflen and waitfor are both 0, we behave like register select */
+     if((globus_xio_operation_get_wait_for(op) == 0 &&
+         (iovec_count > 1 || iovec[0].iov_len > 0)) ||
+@@ -409,7 +409,7 @@ globus_l_xio_pipe_read(
+             iovec_count,
+             globus_xio_operation_get_wait_for(op),
+             &nbytes);
+-        
++
+         globus_xio_driver_finished_read(op, result, nbytes);
+         result = GLOBUS_SUCCESS;
+     }
+@@ -425,7 +425,7 @@ globus_l_xio_pipe_read(
+             globus_l_xio_pipe_system_read_cb,
+             op);
+     }
+-    
++
+     GlobusXIOPipeDebugExit();
+     return result;
+ }
+@@ -439,13 +439,13 @@ globus_l_xio_pipe_system_write_cb(
+ {
+     globus_xio_operation_t              op;
+     GlobusXIOName(globus_l_xio_pipe_system_write_cb);
+-    
++
+     GlobusXIOPipeDebugEnter();
+-    
++
+     op = (globus_xio_operation_t) user_arg;
+-        
++
+     globus_xio_driver_finished_write(op, result, nbytes);
+-    
++
+     GlobusXIOPipeDebugExit();
+ }
+ 
+@@ -464,11 +464,11 @@ globus_l_xio_pipe_write(
+     globus_size_t                       nbytes;
+     globus_result_t                     result;
+     GlobusXIOName(globus_l_xio_pipe_write);
+-    
++
+     GlobusXIOPipeDebugEnter();
+-    
++
+     handle = (xio_l_pipe_handle_t *) driver_specific_handle;
+-                
++
+     /* if buflen and waitfor are both 0, we behave like register select */
+     if((globus_xio_operation_get_wait_for(op) == 0 &&
+         (iovec_count > 1 || iovec[0].iov_len > 0)) ||
+@@ -482,7 +482,7 @@ globus_l_xio_pipe_write(
+             iovec_count,
+             globus_xio_operation_get_wait_for(op),
+             &nbytes);
+-        
++
+         globus_xio_driver_finished_write(op, result, nbytes);
+         result = GLOBUS_SUCCESS;
+     }
+@@ -498,7 +498,7 @@ globus_l_xio_pipe_write(
+             globus_l_xio_pipe_system_write_cb,
+             op);
+     }
+-    
++
+     GlobusXIOPipeDebugExit();
+     return result;
+ }
+@@ -520,11 +520,11 @@ globus_l_xio_pipe_init(
+     globus_xio_driver_t                 driver;
+     globus_result_t                     result;
+     GlobusXIOName(globus_l_xio_pipe_init);
+-    
++
+     GlobusXIOPipeDebugEnter();
+-    
++
+     /* I dont support any driver options, so I'll ignore the ap */
+-    
++
+     result = globus_xio_driver_init(&driver, "file", GLOBUS_NULL);
+     if(result != GLOBUS_SUCCESS)
+     {
+@@ -553,7 +553,7 @@ globus_l_xio_pipe_init(
+         pipe_l_string_opts_table);
+ 
+     *out_driver = driver;
+-    
++
+     GlobusXIOPipeDebugExit();
+     return GLOBUS_SUCCESS;
+ 
+@@ -568,11 +568,11 @@ globus_l_xio_pipe_destroy(
+     globus_xio_driver_t                 driver)
+ {
+     GlobusXIOName(globus_l_xio_pipe_destroy);
+-    
++
+     GlobusXIOPipeDebugEnter();
+-    
++
+     globus_xio_driver_destroy(driver);
+-    
++
+     GlobusXIOPipeDebugExit();
+ }
+ 
+@@ -586,13 +586,13 @@ int
+ globus_l_xio_pipe_activate(void)
+ {
+     int                                 rc;
+-    
++
+     GlobusXIOName(globus_l_xio_pipe_activate);
+-    
++
+     GlobusDebugInit(GLOBUS_XIO_PIPE, TRACE INFO);
+-    
++
+     GlobusXIOPipeDebugEnter();
+-    
++
+     rc = globus_module_activate(GLOBUS_XIO_SYSTEM_MODULE);
+     if(rc != GLOBUS_SUCCESS)
+     {
+@@ -602,9 +602,9 @@ globus_l_xio_pipe_activate(void)
+     xio_l_pipe_attr_default.infd = GetStdHandle(STD_INPUT_HANDLE);
+     xio_l_pipe_attr_default.outfd = GetStdHandle(STD_OUTPUT_HANDLE);
+ #   endif
+-    
++
+     GlobusXIORegisterDriver(pipe);
+-    
++
+     GlobusXIOPipeDebugExit();
+     return GLOBUS_SUCCESS;
+ 
+@@ -619,14 +619,14 @@ int
+ globus_l_xio_pipe_deactivate(void)
+ {
+     GlobusXIOName(globus_l_xio_pipe_deactivate);
+-    
++
+     GlobusXIOPipeDebugEnter();
+-    
++
+     GlobusXIOUnRegisterDriver(pipe);
+     globus_module_deactivate(GLOBUS_XIO_SYSTEM_MODULE);
+-    
++
+     GlobusXIOPipeDebugExit();
+     GlobusDebugDestroy(GLOBUS_XIO_PIPE);
+-    
++
+     return GLOBUS_SUCCESS;
+ }
+-- 
+2.54.0
+

diff --git a/0002-Fix-compiler-and-doxygen-warnings.patch b/0002-Fix-compiler-and-doxygen-warnings.patch
new file mode 100644
index 0000000..576dc9b
--- /dev/null
+++ b/0002-Fix-compiler-and-doxygen-warnings.patch
@@ -0,0 +1,30 @@
+From 4ee08d13e2963309e2063dc45dedd067337d3b76 Mon Sep 17 00:00:00 2001
+From: Mattias Ellert <mattias.ellert@physics.uu.se>
+Date: Wed, 20 May 2026 00:15:37 +0200
+Subject: [PATCH 2/2] Fix compiler and doxygen warnings
+
+---
+ xio/drivers/pipe/source/globus_xio_pipe_driver.c | 3 ---
+ 1 file changed, 3 deletions(-)
+
+diff --git a/xio/drivers/pipe/source/globus_xio_pipe_driver.c b/xio/drivers/pipe/source/globus_xio_pipe_driver.c
+index c99811597..b0f8c71b1 100644
+--- a/xio/drivers/pipe/source/globus_xio_pipe_driver.c
++++ b/xio/drivers/pipe/source/globus_xio_pipe_driver.c
+@@ -208,13 +208,10 @@ globus_result_t
+ globus_l_xio_pipe_attr_destroy(
+     void *                              driver_attr)
+ {
+-    xio_l_pipe_attr_t *                 attr;
+     GlobusXIOName(globus_l_xio_pipe_attr_destroy);
+ 
+     GlobusXIOPipeDebugEnter();
+ 
+-    attr = (xio_l_pipe_attr_t *) driver_attr;
+-
+     globus_free(driver_attr);
+ 
+     GlobusXIOPipeDebugExit();
+-- 
+2.54.0
+

diff --git a/globus-xio-pipe-driver.spec b/globus-xio-pipe-driver.spec
index 2813614..60561c0 100644
--- a/globus-xio-pipe-driver.spec
+++ b/globus-xio-pipe-driver.spec
@@ -1,13 +1,15 @@
 Name:		globus-xio-pipe-driver
 %global _name %(tr - _ <<< %{name})
 Version:	4.1
-Release:	17%{?dist}
+Release:	18%{?dist}
 Summary:	Grid Community Toolkit - Globus Pipe Driver
 
 License:	Apache-2.0
 URL:		https://github.com/gridcf/gct/
 Source:		https://repo.gridcf.org/gct6/sources/%{_name}-%{version}.tar.gz
 Source8:	README
+Patch0:		0001-Untabify-and-remove-trailing-white-space.patch
+Patch1:		0002-Fix-compiler-and-doxygen-warnings.patch
 
 BuildRequires:	make
 BuildRequires:	gcc
@@ -40,6 +42,8 @@ Globus Pipe Driver Development Files
 
 %prep
 %setup -q -n %{_name}-%{version}
+%patch -P0 -p5
+%patch -P1 -p5
 
 %build
 # Reduce overlinking
@@ -81,6 +85,9 @@ rm %{buildroot}%{_pkgdocdir}/GLOBUS_LICENSE
 %{_libdir}/pkgconfig/%{name}.pc
 
 %changelog
+* Sun Jun 14 2026 Mattias Ellert <mattias.ellert@physics.uu.se> - 4.1-18
+- Fix compiler warnings
+
 * Fri Jan 16 2026 Fedora Release Engineering <releng@fedoraproject.org> - 4.1-17
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_44_Mass_Rebuild
 

                 reply	other threads:[~2026-06-14  8:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178142731829.1.12408505091427982024.rpms-globus-xio-pipe-driver-c0213017c744@fedoraproject.org \
    --to=mattias.ellert@physics.uu.se \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox