public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Tom Rix <Tom.Rix@amd.com>
To: git-commits@fedoraproject.org
Subject: [rpms/rccl] epel10: Use bfd/ld for linking
Date: Thu, 11 Jun 2026 14:36:34 GMT [thread overview]
Message-ID: <178118859492.1.5676528140552912516.rpms-rccl-d33985c8451a@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/rccl
Branch : epel10
Commit : d33985c8451a7d0d9f425620fb8caf6c8d69df78
Author : Tom Rix <Tom.Rix@amd.com>
Date : 2026-03-12T10:19:42-07:00
Stats : +19/-1 in 1 file(s)
URL : https://src.fedoraproject.org/rpms/rccl/c/d33985c8451a7d0d9f425620fb8caf6c8d69df78?branch=epel10
Log:
Use bfd/ld for linking
Signed-off-by: Tom Rix <Tom.Rix@amd.com>
---
diff --git a/rccl.spec b/rccl.spec
index b3ec774..df7c639 100644
--- a/rccl.spec
+++ b/rccl.spec
@@ -83,7 +83,7 @@
Name: %{rccl_name}
Version: %{rocm_version}
-Release: 2%{?dist}
+Release: 3%{?dist}
Summary: ROCm Communication Collectives Library
Url: https://github.com/ROCm/rccl
@@ -234,6 +234,21 @@ LINK_JOBS=`eval "expr 1 + ${MEM_GB} / ${LINK_MEM}"`
sed -i -e "s@rccl PRIVATE -parallel-jobs=12@rccl PRIVATE -parallel-jobs=${COMPILE_JOBS}@" CMakeLists.txt
sed -i -e "s@-parallel-jobs=\${num_linker_jobs}@-parallel-jobs=${LINK_JOBS}@" CMakeLists.txt
+# 3/12/26 memory experiment
+# time -v with just gfx1100, 7.2.0
+#
+# Basline: 29.5G
+#
+# -O0 : 26.1G
+# sed -i -e 's@target_link_libraries(rccl PRIVATE -fgpu-rdc)@target_link_libraries(rccl PRIVATE -fgpu-rdc -O0)@' CMakeLists.txt
+#
+# -fuse-ld=bfd : 12.5G
+# sed -i -e 's@target_link_libraries(rccl PRIVATE -fgpu-rdc)@target_link_libraries(rccl PRIVATE -fgpu-rdc -fuse-ld=bfd)@' CMakeLists.txt
+#
+# Switch to bfd
+sed -i -e 's@target_link_libraries(rccl PRIVATE -fgpu-rdc)@target_link_libraries(rccl PRIVATE -fgpu-rdc -fuse-ld=bfd)@' CMakeLists.txt
+
+
%build
%cmake \
-DGPU_TARGETS=%{gpu_list} \
@@ -280,6 +295,9 @@ rm -f %{buildroot}%{pkg_prefix}/share/doc/rccl/LICENSE.txt
%endif
%changelog
+* Thu Mar 12 2026 Tom Rix <Tom.Rix@amd.com> - 7.2.0-3
+- Use bfd/ld from linking
+
* Fri Feb 20 2026 Tom Rix <Tom.Rix@amd.com> - 7.2.0-2
- Cleanup specfile
reply other threads:[~2026-06-11 14:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178118859492.1.5676528140552912516.rpms-rccl-d33985c8451a@fedoraproject.org \
--to=tom.rix@amd.com \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox