public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Jan Horak <jhorak@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/thunderbird] main: Fixed build failures
Date: Thu, 11 Jun 2026 07:37:11 GMT [thread overview]
Message-ID: <178116343158.1.7015527580662334083.rpms-thunderbird-8236ea7e6c91@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/thunderbird
Branch : main
Commit : 8236ea7e6c911c31b8686fe8f89a077e358f7a55
Author : Jan Horak <jhorak@redhat.com>
Date : 2026-06-11T09:36:57+02:00
Stats : +126/-0 in 2 file(s)
URL : https://src.fedoraproject.org/rpms/thunderbird/c/8236ea7e6c911c31b8686fe8f89a077e358f7a55?branch=main
Log:
Fixed build failures
[skip changelog]
---
diff --git a/D303205.1781242667.diff b/D303205.1781242667.diff
new file mode 100644
index 0000000..f4b0743
--- /dev/null
+++ b/D303205.1781242667.diff
@@ -0,0 +1,55 @@
+diff --git a/python/mozbuild/mozbuild/mach_commands.py b/python/mozbuild/mozbuild/mach_commands.py
+--- a/python/mozbuild/mozbuild/mach_commands.py
++++ b/python/mozbuild/mozbuild/mach_commands.py
+@@ -1504,22 +1504,39 @@
+ ensure_exit_code=True,
+ )
+ with open(os.path.join(command_context.topobjdir, "buildid.h")) as fd:
+ _, _, buildid = fd.read().split()
+
+- source_url = ""
+- if substs.get("MOZ_INCLUDE_SOURCE_INFO"):
+- repo = substs.get("MOZ_SOURCE_REPO")
+- changeset = substs.get("MOZ_SOURCE_CHANGESET")
+- if repo and changeset:
+- source_url = f"{repo}/rev/{changeset}"
+-
+ # FIXME: don't create this in topsrcdir
+- with open(
+- os.path.join(command_context.topsrcdir, "sourcestamp.txt"), "w"
+- ) as fd:
+- fd.write(f"{buildid}\n{source_url}")
++ sourcestamp_path = os.path.join(command_context.topsrcdir, "sourcestamp.txt")
++ if conditions.is_thunderbird(command_context):
++ comm_repo = substs.get("MOZ_COMM_SOURCE_REPO")
++ comm_changeset = substs.get("MOZ_COMM_SOURCE_CHANGESET")
++ gecko_repo = substs.get("MOZ_GECKO_SOURCE_REPO")
++ gecko_changeset = substs.get("MOZ_GECKO_SOURCE_CHANGESET")
++
++ # Thunderbird tarball builds require sourcestamp.txt to contain
++ # three lines, e.g.:
++ # 20260522210329
++ # https://hg.mozilla.org/releases/comm-esr140/rev/191059ac655733d24c4fd32c94dfe6d79af7028b
++ # https://hg.mozilla.org/releases/mozilla-esr140/rev/2e36c464a92f1942683abbed6ceb442308db5eb0
++ with open(sourcestamp_path, "w") as fd:
++ fd.write(
++ f"{buildid}\n"
++ f"{comm_repo}/rev/{comm_changeset}\n"
++ f"{gecko_repo}/rev/{gecko_changeset}\n"
++ )
++ else:
++ source_url = ""
++ if substs.get("MOZ_INCLUDE_SOURCE_INFO"):
++ repo = substs.get("MOZ_SOURCE_REPO")
++ changeset = substs.get("MOZ_SOURCE_CHANGESET")
++ if repo and changeset:
++ source_url = f"{repo}/rev/{changeset}"
++
++ with open(sourcestamp_path, "w") as fd:
++ fd.write(f"{buildid}\n{source_url}")
+
+ # this should match SOURCE_TAR in packager.mk.
+ archive_prefix = f"{substs['MOZ_APP_NAME']}-{substs['MOZ_APP_VERSION']}"
+ archive_path = os.path.join(
+ substs["DIST"], output or f"{archive_prefix}.tar.xz"
+
diff --git a/D303424.1781004200.diff b/D303424.1781004200.diff
new file mode 100644
index 0000000..2abbd65
--- /dev/null
+++ b/D303424.1781004200.diff
@@ -0,0 +1,71 @@
+diff -up thunderbird-151.0.1/comm/build/moz.configure/gecko_source.configure.D303424.1781004200 thunderbird-151.0.1/comm/build/moz.configure/gecko_source.configure
+--- thunderbird-151.0.1/comm/build/moz.configure/gecko_source.configure.D303424.1781004200 2026-05-23 15:31:09.000000000 +0200
++++ thunderbird-151.0.1/comm/build/moz.configure/gecko_source.configure 2026-06-11 07:55:19.312957046 +0200
+@@ -47,11 +47,11 @@ def read_sourcestamp(repository):
+ if exists(sourcestamp_file):
+ try:
+ lines = open(sourcestamp_file).readlines()
+- except:
+- pass
++ except OSError:
++ lines = []
+
+ if len(lines) != 3:
+- log.warn("sourcestamp.txt is corrupt!")
++ log.info("sourcestamp.txt is corrupt!")
+ return
+
+ if lines and lines[line2read].startswith("http"):
+diff -up thunderbird-151.0.1/comm/build/source_repos.py.D303424.1781004200 thunderbird-151.0.1/comm/build/source_repos.py
+--- thunderbird-151.0.1/comm/build/source_repos.py.D303424.1781004200 2026-05-23 15:31:09.000000000 +0200
++++ thunderbird-151.0.1/comm/build/source_repos.py 2026-06-11 07:48:25.166215765 +0200
+@@ -2,16 +2,10 @@
+ # License, v. 2.0. If a copy of the MPL was not distributed with this
+ # file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+-import os
+ import sys
+
+ import buildconfig
+
+-sourcestamp_tmpl = """{buildid}
+-{comm_repo}/rev/{comm_rev}
+-{gecko_repo}/rev/{gecko_rev}
+-"""
+-
+
+ def mk_hg_url(repo, revision):
+ """
+@@ -39,18 +33,6 @@ def gen_platformini(output, platform_ini
+ output.write("platform.ini updated.\n")
+
+
+-def gen_sourcestamp(output):
+- data = dict(
+- buildid=os.environ.get("MOZ_BUILD_DATE", "unknown"),
+- gecko_repo=buildconfig.substs.get("MOZ_GECKO_SOURCE_REPO", None),
+- gecko_rev=buildconfig.substs.get("MOZ_GECKO_SOURCE_CHANGESET", None),
+- comm_repo=buildconfig.substs.get("MOZ_COMM_SOURCE_REPO", None),
+- comm_rev=buildconfig.substs.get("MOZ_COMM_SOURCE_CHANGESET", None),
+- )
+-
+- output.write(sourcestamp_tmpl.format(**data))
+-
+-
+ def source_repo_header(output):
+ """
+ Appends the Gecko source repository information to source-repo.h
+diff -up thunderbird-151.0.1/comm/mail/installer/Makefile.in.D303424.1781004200 thunderbird-151.0.1/comm/mail/installer/Makefile.in
+--- thunderbird-151.0.1/comm/mail/installer/Makefile.in.D303424.1781004200 2026-05-23 15:31:10.000000000 +0200
++++ thunderbird-151.0.1/comm/mail/installer/Makefile.in 2026-06-11 07:48:25.166306205 +0200
+@@ -206,10 +206,6 @@ package-compare:: $(MOZ_PKG_MANIFEST)
+ -diff -u $(DIST)/pack-list.txt $(DIST)/bin-list.txt
+ rm -f $(DIST)/pack-list.txt $(DIST)/bin-list.txt
+
+-# Overwrite the one made by Firefox with our own.
+-make-sourcestamp-file::
+- $(PYTHON3) $(commtopsrcdir)/build/source_repos.py gen_sourcestamp > $(MOZ_SOURCESTAMP_FILE)
+-
+ ifdef ENABLE_WEBDRIVER
+ DEFINES += -DENABLE_WEBDRIVER=1
+ endif
next reply other threads:[~2026-06-11 7:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 7:37 Jan Horak [this message]
2026-06-11 7:37 [rpms/thunderbird] main: Fixed build failures Jan Horak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178116343158.1.7015527580662334083.rpms-thunderbird-8236ea7e6c91@fedoraproject.org \
--to=jhorak@redhat.com \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox