public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Jos de Kloe <josdekloe@gmail.com>
To: git-commits@fedoraproject.org
Subject: [rpms/pygrib] rawhide: Fix 3 failing tests by applying 3 workarounds needed due to slight projection change after proj update from 9.7.1 to 9.8.0
Date: Sat, 06 Jun 2026 20:34:55 GMT	[thread overview]
Message-ID: <178077809543.1.11106650512962811447.rpms-pygrib-77a042e154b7@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/pygrib
Branch : rawhide
Commit : 77a042e154b75a89562ee8c34f8811429514273b
Author : Jos de Kloe <josdekloe@gmail.com>
Date   : 2026-06-06T22:33:40+02:00
Stats  : +44/-1 in 4 file(s)
URL    : https://src.fedoraproject.org/rpms/pygrib/c/77a042e154b75a89562ee8c34f8811429514273b?branch=rawhide

Log:
Fix 3 failing tests by applying 3 workarounds needed due to slight projection change after proj update from 9.7.1 to 9.8.0

---
diff --git a/pygrib-test_lambert.patch b/pygrib-test_lambert.patch
new file mode 100644
index 0000000..6a6f2a4
--- /dev/null
+++ b/pygrib-test_lambert.patch
@@ -0,0 +1,11 @@
+--- pygrib-2.1.8.unchanged/test/test_lambert.py	2025-10-23 17:42:09.000000000 +0200
++++ pygrib-2.1.8/test/test_lambert.py	2026-06-06 21:17:59.929317273 +0200
+@@ -15,7 +15,7 @@ pj = ccrs.LambertConformal(globe=globe,c
+      central_latitude=grb.projparams['lat_0'],
+      standard_parallels =(grb.projparams['lat_1'],grb.projparams['lat_2']))
+ 
+-@pytest.mark.mpl_image_compare(tolerance=20,remove_text=True)
++@pytest.mark.mpl_image_compare(tolerance=38,remove_text=True)
+ def test_lambert():
+     fig = plt.figure()
+     ax = plt.axes(projection=pj)

diff --git a/pygrib-test_rotated_ll.patch b/pygrib-test_rotated_ll.patch
new file mode 100644
index 0000000..756fe67
--- /dev/null
+++ b/pygrib-test_rotated_ll.patch
@@ -0,0 +1,11 @@
+--- pygrib-2.1.8.unchanged/test/test_rotated_ll.py	2025-10-23 17:42:09.000000000 +0200
++++ pygrib-2.1.8/test/test_rotated_ll.py	2026-06-06 21:18:18.079906784 +0200
+@@ -15,7 +15,7 @@ sys.stdout.write(repr(grb.projparams)+'\
+ globe = ccrs.Globe(ellipse='sphere', semimajor_axis=grb.projparams['a'], semiminor_axis=grb.projparams['b'])
+ pj = ccrs.Stereographic(globe=globe,central_longitude=10,central_latitude=55)
+ 
+-@pytest.mark.mpl_image_compare(tolerance=20,remove_text=True)
++@pytest.mark.mpl_image_compare(tolerance=25,remove_text=True)
+ def test_rotated_ll():
+     fig = plt.figure()
+     ax = plt.axes(projection=pj)

diff --git a/pygrib-test_stere.patch b/pygrib-test_stere.patch
new file mode 100644
index 0000000..a4c3d22
--- /dev/null
+++ b/pygrib-test_stere.patch
@@ -0,0 +1,11 @@
+--- pygrib-2.1.8.unchanged/test/test_stere.py	2025-10-23 17:42:09.000000000 +0200
++++ pygrib-2.1.8/test/test_stere.py	2026-06-06 21:18:33.938548066 +0200
+@@ -16,7 +16,7 @@ pj = ccrs.Stereographic(globe=globe,cent
+      central_latitude=grb.projparams['lat_0'],
+      true_scale_latitude=grb.projparams['lat_ts']) 
+ 
+-@pytest.mark.mpl_image_compare(tolerance=20,remove_text=True)
++@pytest.mark.mpl_image_compare(tolerance=30,remove_text=True)
+ def test_stere1():
+     fig = plt.figure()
+     ax = plt.axes(projection=pj)

diff --git a/pygrib.spec b/pygrib.spec
index c77f416..23f2927 100644
--- a/pygrib.spec
+++ b/pygrib.spec
@@ -3,7 +3,7 @@
 
 Name:       pygrib
 Version:    2.1.8
-Release:    2%{?dist}
+Release:    3%{?dist}
 Summary:    Python module for reading and modifying GRIB files
 
 # this software uses the "MIT:Modern Style with sublicense" license
@@ -30,6 +30,13 @@ Patch1: %{name}-build.patch
 # See https://github.com/jswhit/pygrib/issues/256
 Patch2: %{name}-test-gaussian.patch
 
+# 3 workarounds needed due to slight projection change after
+# proj update from 9.7.1 to 9.8.0
+# See https://github.com/jswhit/pygrib/issues/282
+Patch3: %{name}-test_lambert.patch
+Patch4: %{name}-test_rotated_ll.patch
+Patch5: %{name}-test_stere.patch
+
 # exclude architectures not supported by eccodes
 # as explained in bugzilla #1562066
 ExcludeArch: i686
@@ -185,6 +192,9 @@ cd  $TESTROOT/test
 %{_mandir}/man1/grib_*
 
 %changelog
+* Sat Jun 06 2026 Jos de Kloe <josdekloe@gmail.com> 2.1.8-3
+- Fix 3 failing tests
+
 * Sat Jan 17 2026 Fedora Release Engineering <releng@fedoraproject.org> - 2.1.8-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_44_Mass_Rebuild
 

                 reply	other threads:[~2026-06-06 20:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178077809543.1.11106650512962811447.rpms-pygrib-77a042e154b7@fedoraproject.org \
    --to=josdekloe@gmail.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox