public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Yaakov Selkowitz <yselkowi@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/transmission] f44: Fix flatpak build
Date: Wed, 03 Jun 2026 18:04:37 GMT	[thread overview]
Message-ID: <178050987714.1.5325924645255580505.rpms-transmission-83d8244d3616@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/transmission
            Branch : f44
            Commit : 83d8244d3616b6b7d61d61cb37a1afc77a1a65a8
            Author : Yaakov Selkowitz <yselkowi@redhat.com>
            Date   : 2026-03-20T02:39:59-04:00
            Stats  : +3/-3 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/transmission/c/83d8244d3616b6b7d61d61cb37a1afc77a1a65a8?branch=f44

            Log:
            Fix flatpak build

The buildsystem now installs the systemd service file, which is unused in
flatpaks, but does not respect %_unitdir when building into another prefix.

---
diff --git a/transmission.spec b/transmission.spec
index b9aa6a8..849d537 100644
--- a/transmission.spec
+++ b/transmission.spec
@@ -120,7 +120,7 @@ EOF
 CXXFLAGS="%{optflags} -fPIC"
 CFLAGS="%{optflags} -fPIC"
 
-%cmake -DCMAKE_BUILD_TYPE=Release -DENABLE_CLI=ON -DENABLE_QT=ON -DUSE_QT_VERSION=6 -DENABLE_GTK=ON -DUSE_GTK_VERSION=4
+%cmake -DCMAKE_BUILD_TYPE=Release -DENABLE_CLI=ON -DENABLE_QT=ON -DUSE_QT_VERSION=6 -DENABLE_GTK=ON -DUSE_GTK_VERSION=4 %{?flatpak:-DWITH_SYSTEMD=OFF}
 %cmake_build
 
 # Re-enable if DhtTest.usesBootstrapFile passes
@@ -128,8 +128,6 @@ CFLAGS="%{optflags} -fPIC"
 #%%ctest
 
 %install
-mkdir -p %{buildroot}%{_unitdir}
-install -m0644 redhat-linux-build/daemon/transmission-daemon.service  %{buildroot}%{_unitdir}/
 mkdir -p %{buildroot}%{_sharedstatedir}/transmission
 %cmake_install
 
@@ -180,7 +178,9 @@ install -m0644 -D transmission.sysusers.conf %{buildroot}%{_sysusersdir}/transmi
 
 %files daemon
 %{_bindir}/transmission-daemon
+%if !0%{?flatpak}
 %{_unitdir}/transmission-daemon.service
+%endif
 %attr(-,transmission, transmission)%{_sharedstatedir}/transmission/
 %doc %{_mandir}/man1/transmission-daemon*
 %{_sysusersdir}/transmission.conf

                 reply	other threads:[~2026-06-03 18:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178050987714.1.5325924645255580505.rpms-transmission-83d8244d3616@fedoraproject.org \
    --to=yselkowi@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox