public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Paul Howarth <paul@city-fan.org>
To: git-commits@fedoraproject.org
Subject: [rpms/perl-Perl-Critic] rawhide: Run tests with LANG=en_US.UTF-8 to fix pod spelling test on Rawhide
Date: Mon, 01 Jun 2026 10:54:58 GMT	[thread overview]
Message-ID: <178031129856.1.5974095560331644161.rpms-perl-Perl-Critic-7b4f5588aab6@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/perl-Perl-Critic
            Branch : rawhide
            Commit : 7b4f5588aab676ab9fcb19b1ad27f47d867d77ad
            Author : Paul Howarth <paul@city-fan.org>
            Date   : 2026-06-01T11:53:26+01:00
            Stats  : +6/-5 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/perl-Perl-Critic/c/7b4f5588aab676ab9fcb19b1ad27f47d867d77ad?branch=rawhide

            Log:
            Run tests with LANG=en_US.UTF-8 to fix pod spelling test on Rawhide

Running without the ".UTF-8" resulted in errors being triggered for
parts of contractions like "isn" and "doesn".

---
diff --git a/perl-Perl-Critic.spec b/perl-Perl-Critic.spec
index 35a0230..d1ed39c 100644
--- a/perl-Perl-Critic.spec
+++ b/perl-Perl-Critic.spec
@@ -7,7 +7,7 @@
 
 Name:		perl-Perl-Critic
 Version:	1.156
-Release:	4%{?dist}
+Release:	5%{?dist}
 Summary:	Critique Perl source code for best-practices
 License:	GPL-1.0-or-later OR Artistic-1.0-Perl
 URL:		https://metacpan.org/release/Perl-Critic
@@ -68,9 +68,7 @@ BuildRequires:	perl(version) >= 0.77
 BuildRequires:	perl(warnings)
 
 # Main test suite
-%if 0%{?fedora} > 23 || 0%{?rhel} > 7
 BuildRequires:	glibc-langpack-en
-%endif
 BuildRequires:	perl(File::Spec::Functions)
 BuildRequires:	perl(Test::Memory::Cycle)
 BuildRequires:	perl(Test::More)
@@ -142,9 +140,9 @@ perl Build.PL --installdirs=vendor
 
 %check
 %if 0%{!?perl_bootstrap:1} && %{with perl_Perl_Critic_enables_extra_test}
-LC_ALL=en_US ./Build authortest
+LANG=en_US.UTF-8 ./Build authortest
 %else
-LC_ALL=en_US ./Build test
+LANG=en_US.UTF-8 ./Build test
 %endif
 
 %files
@@ -160,6 +158,9 @@ LC_ALL=en_US ./Build test
 %{_mandir}/man3/Test::Perl::Critic::Policy.3*
 
 %changelog
+* Mon Jun  1 2026 Paul Howarth <paul@city-fan.org> - 1.156-5
+- Run tests with LANG=en_US.UTF-8 to fix pod spelling test on Rawhide
+
 * Sat Jan 17 2026 Fedora Release Engineering <releng@fedoraproject.org> - 1.156-4
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_44_Mass_Rebuild
 

                 reply	other threads:[~2026-06-01 10:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178031129856.1.5974095560331644161.rpms-perl-Perl-Critic-7b4f5588aab6@fedoraproject.org \
    --to=paul@city-fan.org \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox