public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Filipe Rosset <rosset.filipe@gmail.com>
To: git-commits@fedoraproject.org
Subject: [rpms/homebank] f43: Modernize spec: use %make_install and add %check section
Date: Sat, 30 May 2026 22:20:08 GMT	[thread overview]
Message-ID: <178017960845.1.15197901511427618917.rpms-homebank-2d0505f89298@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/homebank
            Branch : f43
            Commit : 2d0505f892984c73b2e5f2aee20d60aa8c3f9b5a
            Author : Filipe Rosset <rosset.filipe@gmail.com>
            Date   : 2026-03-12T21:51:03-03:00
            Stats  : +5/-13 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/homebank/c/2d0505f892984c73b2e5f2aee20d60aa8c3f9b5a?branch=f43

            Log:
            Modernize spec: use %make_install and add %check section

- Use %make_install instead of manual make install
- Move validation to %check
- Remove deprecated %ldconfig_scriptlets
- Fix trailing whitespace in Summary

---
diff --git a/homebank.spec b/homebank.spec
index c00ca04..92bf6bd 100644
--- a/homebank.spec
+++ b/homebank.spec
@@ -1,7 +1,7 @@
 Name:           homebank
 Version:        5.10
 Release:        %{autorelease}
-Summary:        Free easy personal accounting for all  
+Summary:        Free easy personal accounting for all
 License:        GPL-2.0-or-later
 URL:            https://gethomebank.org/
 Source0:        https://gethomebank.org/public/sources/%{name}-%{version}.tar.gz
@@ -43,20 +43,12 @@ chmod -x src/*.*
 %make_build
 
 %install
-make install DESTDIR=%{buildroot} INSTALL='install -p'
-mkdir -p %{buildroot}%{_datadir}/pixmaps
-mkdir -p %{buildroot}%{_datadir}/applications
-desktop-file-install                                    \
-        --delete-original                               \
-        --dir %{buildroot}%{_datadir}/applications   \
-        --mode 0644                                     \
-        %{buildroot}%{_datadir}/applications/%{name}.desktop
-
+%make_install
 %find_lang %{name}
 
-appstream-util validate-relax --nonet %{buildroot}/%{_datadir}/metainfo/%{name}.appdata.xml
-
-%ldconfig_scriptlets
+%check
+desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop
+appstream-util validate-relax --nonet %{buildroot}%{_datadir}/metainfo/%{name}.appdata.xml
 
 %files -f %{name}.lang
 %doc AUTHORS ChangeLog NEWS README

                 reply	other threads:[~2026-05-30 22:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178017960845.1.15197901511427618917.rpms-homebank-2d0505f89298@fedoraproject.org \
    --to=rosset.filipe@gmail.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox